-
Notifications
You must be signed in to change notification settings - Fork 1
feat(routing): Goal Classifier Router for planner model selection (TD-195) #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
31505c9
docs(goal-classifier-router): scaffold spec + CHANGELOG scope
engkimo 0316f75
feat(domain): T010-T015 PlannerModel, GoalClassification, GoalClassif…
engkimo 9e30401
feat(domain): T020-T021 GoalClassifierPort ABC
engkimo 679c292
test(_fakes): T030 InMemoryGoalClassifier port-compliant fake
engkimo 5ff44e9
refactor(domain): align ReasonCategory Literal with plan.md AD-3 taxo…
engkimo 4a2be8d
feat(domain): T040-T041 PlannerModelRouter with AD-2 gating + AD-3 no…
engkimo ac496a4
feat(infrastructure): T050-T051 shared classifier prompt + parser
engkimo 405d0d3
feat(infrastructure): T060-T071 LLMGoalClassifier (remote) + LocalGoa…
engkimo cbf3b41
feat(infrastructure): T080-T081 wire PlannerModelRouter into LLMPlanner
engkimo 840b3d3
feat(config): T090 add planner router settings (MORPHIC_PLANNER_ROUTER)
engkimo f6a6ce7
feat(interface): T091 wire PlannerModelRouter into AppContainer
engkimo dcdec38
feat(observability): T100-T101 RouterMetrics + RouterObservingEventBus
engkimo 58df4a1
feat(routing): T110-T111 live integration tests + RouterObservingEven…
engkimo 00df10a
bench(planner): T120 — add --router mode for AD-4 per-goal routing
engkimo e49499c
bench(planner): T121 — live 3-arm A/B dump (TD-195 router)
engkimo e1428fc
docs: T130-T132 — TD-195 ADR + ENV_VARS + CONTINUATION update
engkimo 53bc64d
style(routing): T140 — ruff cleanup for router test files
engkimo ba605c1
docs: fix TD-195 env-var values flagged in self-review
engkimo 4b2c75e
fix(td-195): address CodeRabbit Major findings before merge
engkimo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add deterministic key ordering to benchmark JSON dumps.
At Lines 504-506, serialization omits
sort_keys=True, which makes dump ordering unstable across runs and creates avoidable diff noise.Proposed patch
As per coding guidelines, JSON/YAML serialization must use
sort_keys=Truefor deterministic output.🤖 Prompt for AI Agents