Skip to content

Fix test_rounding for recent LLVM change #26975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kripken wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix test_rounding for recent LLVM change #26975

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c82ef3f
fix
kripken May 18, 2026
f51a95a
skip instead
kripken May 18, 2026
81482fa
use unknown-warning
kripken May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,8 @@ def test_math_fmodf(self):
self.do_run_in_out_file_test('math/fmodf.c')

def test_rounding(self):
self.do_core_test('test_rounding.c')
self.skipTest('https://github.com/emscripten-core/emscripten/pull/26975')
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use -Wno-unknown-warning-option for this :)

Copy link
Copy Markdown
Member Author

@kripken kripken May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, thanks. Done. Maybe some day I'll get this PR right...

self.do_core_test('test_rounding.c', cflags=['-Wno-fenv-access'])

def test_stack(self):
self.set_setting('INLINING_LIMIT')
Expand Down
Loading