Skip to content

Add multithreaded variant of lua port #26886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrnickzh wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −4
Open

Add multithreaded variant of lua port #26886

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9758e9e
Update lua.py
mrnickzh May 7, 2026
7a3b8b2
Update lua.py
mrnickzh May 7, 2026
a89ea08
Update test_other.py
mrnickzh May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions tools/ports/contrib/lua.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
LICENSE = 'MIT License'

port_name = 'contrib.lua'
lib_name = 'liblua.a'
lib_name = 'liblua'


def get(ports, settings, shared):
Expand All @@ -36,10 +36,15 @@ def create(final):
ldblib.c liolib.c lmathlib.c loadlib.c loslib.c lstrlib.c ltablib.c lutf8lib.c linit.c
'''.split()

ports.build_port(source_path, final, port_name, srcs=srcs)
flags=[]

return [shared.cache.get_lib(lib_name, create, what='port')]
if settings.PTHREADS:
flags += ['-pthread']

ports.build_port(source_path, final, port_name, srcs=srcs, flags=flags)

return [shared.cache.get_lib(lib_name + ('-mt' if settings.PTHREADS else '') + '.a', create, what='port')]


def clear(ports, settings, shared):
shared.cache.erase_lib(lib_name)
shared.cache.erase_lib(lib_name + ('-mt' if settings.PTHREADS else '') + '.a')
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convention is to add get_lib_name function.

You will also want to add a variants mapping so that embuilder can build the different variants.

Copy link
Copy Markdown
Author

@mrnickzh mrnickzh May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i fixed it, thanks
and also fixed the name of the issue