-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update musl to v1.2.6 #26860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update musl to v1.2.6 #26860
Changes from 15 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
8afc084
musl: revert Emscripten-specific changes
kleisauke aabc8b2
musl: update arch ignore list
kleisauke fa6d187
Update musl to v1.2.6
kleisauke a67d130
musl: reapply Emscripten-specific changes
kleisauke 82cc2d3
Revise Emscripten-specific changes
kleisauke 2bd5f45
Revise Emscripten-specific include changes
kleisauke 85d99f0
Revise arch/emscripten/bits changes
kleisauke e019d33
Deduplicate arch/emscripten/bits directory
kleisauke b97ab49
Regenerate struct info files
kleisauke 0da9cf9
Update README.md and ChangeLog.md
kleisauke 7378ee6
Re-order to match stat struct
kleisauke 6d50b1c
Update `system_libs.py` after musl v1.2.6
kleisauke 3d7b8f3
Fix `other.test_standalone_whole_archive` failure
kleisauke 7d0afe6
Automatic rebaseline of codesize expectations. NFC
kleisauke 1ef60da
Merge branch 'main' into musl-1.2.6
kleisauke 1f05268
Revert "Revise Emscripten-specific include changes"
kleisauke a499fc2
Revert "Revise Emscripten-specific changes"
kleisauke 9ac8462
Remove generic `<bits/stdarg.h>` header
kleisauke 48c2c80
Merge branch 'main' into musl-1.2.6
kleisauke 060d10f
Automatic rebaseline of codesize expectations. NFC
kleisauke a62785a
Remove outdated comment
kleisauke abfd52c
Revert "Fix `other.test_standalone_whole_archive` failure"
kleisauke 0f0d7c0
Fix `other.test_standalone_whole_archive` failure
kleisauke 4a51319
Automatic rebaseline of codesize expectations. NFC
kleisauke 4d7f929
Merge branch 'main' into musl-1.2.6
kleisauke 4289e41
Make `update_musl.py` more precise. NFC
kleisauke ae38f6f
Remove `arch/generic/bits/stdint.h`
kleisauke 518eaad
Automatic rebaseline of codesize expectations. NFC
kleisauke d7aeb05
Revert "Re-order to match stat struct"
kleisauke b93b9e1
Merge branch 'main' into musl-1.2.6
kleisauke 6a35951
Automatic rebaseline of codesize expectations. NFC
kleisauke 29fc8dd
Revert stat struct field reordering
kleisauke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -260,10 +260,10 @@ addToLibrary({ | |
| size: {{{ makeGetValue('statBuf', C_STRUCTS.stat.st_size, "i53") }}}, | ||
| blksize: {{{ makeGetValue('statBuf', C_STRUCTS.stat.st_blksize, "i32") }}}, | ||
| blocks: {{{ makeGetValue('statBuf', C_STRUCTS.stat.st_blocks, "i32") }}}, | ||
| ino: {{{ makeGetValue('statBuf', C_STRUCTS.stat.st_ino, "u53") }}}, | ||
| atime: {{{ makeGetValue('statBuf', C_STRUCTS.stat.st_atim.tv_sec, "i53") }}}, | ||
| mtime: {{{ makeGetValue('statBuf', C_STRUCTS.stat.st_mtim.tv_sec, "i53") }}}, | ||
| ctime: {{{ makeGetValue('statBuf', C_STRUCTS.stat.st_ctim.tv_sec, "i53") }}}, | ||
| ino: {{{ makeGetValue('statBuf', C_STRUCTS.stat.st_ino, "u53") }}} | ||
| ctime: {{{ makeGetValue('statBuf', C_STRUCTS.stat.st_ctim.tv_sec, "i53") }}} | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto |
||
| } | ||
| }, | ||
| stat(path) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 1.2.5 | ||
| 1.2.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| #define PAGE_SIZE 65536 | ||
| // A value used historically in Emscripten, and which we don't have a strong | ||
| // reason to change so far. | ||
| #define PAGESIZE 65536 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| // XXX Emscripten in sync with both: | ||
| // - musl/arch/x86_64/bits/mman.h | ||
| // - musl/arch/i386/bits/mman.h | ||
| #define MAP_32BIT 0x40 |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| // XXX Emscripten in sync with musl/arch/i386/bits/setjmp.h | ||
| typedef unsigned long __jmp_buf[6]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like just a re-ordering? Revert this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was re-ordered to match the stat struct, see commit 7378ee6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... though I can revert this, I need to resolve the merge conflicts anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, let's revert this
statstruct field reordering. I forgot that changing the layout breaks Rust compatibility, see for example:https://github.com/rust-lang/libc/blob/0.2.186/src/unix/linux_like/linux/musl/b32/x86/mod.rs#L9-L48
versus:
https://github.com/rust-lang/libc/blob/0.2.186/src/unix/linux_like/emscripten/mod.rs#L217-L240
See also rust-lang/rust#131467, where a similar change caused a significant amount of churn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ordering of assignments in JS doesn't not need to match the ordering in native code necessarily.
I don't really care of we keep the old ordering on the native side but it seems very bad if rust depends on this ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted with commit d7aeb05 and 29fc8dd to be on the safe side.