Add metric to count number of non-deactivated users.

changelog.d/19848.feature

@@ -0,0 +1 @@
+Add new metric `synapse_admin_user_count` which tracks the number of non-deactivated users in the database, split by `app_service`.

pyproject.toml

@@ -61,9 +61,8 @@ dependencies = [
     "msgpack>=0.5.2",
     "phonenumbers>=8.2.0",
     # we use GaugeHistogramMetric, which was added in prom-client 0.4.0.
-    # `prometheus_client.metrics` was added in 0.5.0, so we require that too.
-    # We chose 0.6.0 as that is the current version in Debian Buster (oldstable).
-    "prometheus-client>=0.6.0",
+    # `Gauge.clear()` was added in 0.10.0.
+    "prometheus-client>=0.10.0",
     # we use `order`, which arrived in attrs 19.2.0.
     # Note: 21.1.0 broke `/sync`, see https://github.com/matrix-org/synapse/issues/9936
     "attrs>=19.2.0,!=21.1.0",

synapse/app/phone_stats_home.py

@@ -73,6 +73,11 @@
     "Registered users with reserved threepids",
     labelnames=[SERVER_NAME_LABEL],
 )
+user_count_gauge = Gauge(
+    "synapse_admin_user_count",
+    "Total active (non-deactivated) user count within the Synapse database, split by appservice",
+    labelnames=["app_service", SERVER_NAME_LABEL],
+)
 
 
 def phone_stats_home(
@@ -261,6 +266,28 @@ async def _generate_monthly_active_users() -> None:
             _generate_monthly_active_users,
         )
 
+    def generate_total_users() -> "defer.Deferred[None]":
+        async def _generate_total_users() -> None:
+            store = hs.get_datastores().main
+
+            result = await store.get_user_count_by_service()
+
+            user_count_gauge.clear()
+
+            for app_service, count in result:
+                user_count_gauge.labels(
+                    app_service=app_service, **{SERVER_NAME_LABEL: server_name}
+                ).set(float(count))
+
+        return hs.run_as_background_process(
+            "generate_total_users",
+            _generate_total_users,
+        )
+
+    if hs.config.metrics.enable_metrics:
+        generate_total_users()
+        clock.looping_call(generate_total_users, Duration(minutes=5))
+
     if hs.config.server.limit_usage_by_mau or hs.config.server.mau_stats_only:
         generate_monthly_active_users()
         clock.looping_call(generate_monthly_active_users, Duration(minutes=5))

synapse/storage/databases/main/registration.py

@@ -1133,6 +1133,33 @@ def _count_users(txn: LoggingTransaction) -> int:
 
         return await self.db_pool.runInteraction("count_real_users", _count_users)
 
+    async def get_user_count_by_service(self) -> list[tuple[str, int]]:
+        """Counts users grouped by their appservice.
+
+        Returns:
+            A list of tuples (appservice_id, count). "native" is emitted as the
+            appservice for users that don't come from appservices (i.e. native Matrix
+            users).
+
+        """
+
+        def _get_user_count_by_service(
+            txn: LoggingTransaction,
+        ) -> list[tuple[str, int]]:
+            sql = """
+                SELECT COALESCE(NULLIF(appservice_id, ''), 'native') AS app_service, COUNT(*) AS count
+                FROM users
+                WHERE deactivated = 0
+                GROUP BY COALESCE(NULLIF(appservice_id, ''), 'native')
+            """
+
+            txn.execute(sql)
+            return cast(list[tuple[str, int]], txn.fetchall())
+
+        return await self.db_pool.runInteraction(
+            "get_user_count_by_service", _get_user_count_by_service
+        )
+
     async def generate_user_id(self) -> str:
         """Generate a suitable localpart for a guest user