[8.19] [CI] remove yarn.lock, adjust configs (#291037)

.buildkite/scripts/pipelines/pull_request/pipeline.ts

@@ -50,7 +50,7 @@ const SKIPPABLE_PR_MATCHERS = prConfig.skip_ci_on_only_changed!.map((r) => new R
 
 // this covers external dependency changes, which the package graph below cannot see.
 const STORYBOOK_BUILD_CRITICAL_PATHS = [
-  /^yarn\.lock$/,
+  /^pnpm-lock\.yaml$/,
   /^pnpm-workspace\.yaml$/,
   /^\.buildkite\/scripts\/steps\/storybooks\//,
 ];

.buildkite/scripts/steps/esql_generate_function_metadata.sh

@@ -50,7 +50,7 @@ main () {
 
   # Check for differences
   set +e
-  git diff --exit-code --quiet $GIT_SCOPE 
+  git diff --exit-code --quiet $GIT_SCOPE
   if [ $? -eq 0 ]; then
     echo "No differences found. Our work is done here."
     exit
@@ -82,6 +82,9 @@ main () {
   git checkout -b "$BRANCH_NAME"
 
   git add $GIT_SCOPE
+  if [ "$VERSION_BUMPED" == "true" ]; then
+    git add package.json pnpm-lock.yaml
+  fi
   git commit -m "Update function metadata"
 
   report_main_step "Changes committed. Creating pull request."

.gitignore

@@ -95,6 +95,7 @@ selenium
 *.out
 package-lock.json
 !/.buildkite/package-lock.json
+yarn.lock
 .yo-rc.json
 .vscode
 *.sublime-*

packages/kbn-eslint-config/.gitignore

@@ -33,4 +33,5 @@ node_modules
 .node_repl_history
 .eslintrc.json
 
-yarn.lock
+yarn.lock
+pnpm-lock.yaml

packages/kbn-yarn-lock-validator/README.mdx

@@ -4,10 +4,10 @@ slug: /kibana-dev-docs/ops/kbn-yarn-lock-validator
 title: "@kbn/yarn-lock-validator"
 description: 'A tool for validating specific conditions for our dependency chain'
 date: 2022-07-14
-tags: ['kibana', 'dev', 'contributor', 'operations', 'packages', 'scripts', 'yarn']
+tags: ['kibana', 'dev', 'contributor', 'operations', 'packages', 'scripts', 'pnpm']
 ---
 
-`@kbn/yarn-lock-validator` provides yarn.lock validation logic for the Kibana project. It is loaded up by <DocLink id="kibDevDocsOpsKbnPm" /> after bootstrap and validates that we haven't accidentally re-introduced specific dependencies or version-combination scenarios detailed below:
+`@kbn/yarn-lock-validator` provides pnpm lockfile validation logic for the Kibana project. It is loaded up by <DocLink id="kibDevDocsOpsKbnPm" /> after bootstrap and validates that we haven't accidentally re-introduced specific dependencies or version-combination scenarios detailed below:
 
 ## validation scenarios
 

x-pack/solutions/observability/plugins/apm/scripts/.gitignore

@@ -1 +1,2 @@
 yarn.lock
+pnpm-lock.yaml