Skip to content

[Alerting V2] Restructure Action Policy form with described form groups and progressive disclosure - #290907

Open
miguelmartin-elastic wants to merge 6 commits into
elastic:mainfrom
miguelmartin-elastic:feat/restructure-action-policy-form-described-groups-1050
Open

[Alerting V2] Restructure Action Policy form with described form groups and progressive disclosure#290907
miguelmartin-elastic wants to merge 6 commits into
elastic:mainfrom
miguelmartin-elastic:feat/restructure-action-policy-form-described-groups-1050

Conversation

@miguelmartin-elastic

@miguelmartin-elastic miguelmartin-elastic commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

📄 Summary

Important

Alerting v2 work under a feature flag disabled by default. See Verification steps > Environment Setup.

Before After
Screen.Recording.2026-09-14.at.16.10.33.mov
Screen.Recording.2026-09-14.at.16.11.10.mov

Restructures the Action Policy create/edit form so explanatory copy no longer sits in the same visual path as the controls. The four sections now use EuiDescribedFormGroup (description on the left, fields on the right), the Notification controls section shows a live summary on the left, and the Frequency helper text moves into an info-icon popover. Layout / progressive-disclosure only — no schema, dispatch, or API behavior changes.

Changes

  • Convert the four form sections (Policy details, Policy scope, Notification controls, Destination) from stacked EuiSplitPanels to EuiDescribedFormGroup, with horizontal dividers between them.
  • Move the Notification summary to the left column of Notification controls as a live NotificationSummary component: it reads form state via useWatch and shows the selected notify-per mode description plus the resulting outcome. Removed from below the fields.
  • Remove the mode helper text under "Notify per" (now in the summary).
  • Replace the Frequency helper text with an info icon next to the label that opens a popover listing every frequency option for the current mode with its explanation (FrequencyHelpTip, EuiPopover — opens on hover, click, and keyboard focus).
  • Rename dispatch_config_summary.tsxnotification_summary.tsx (outcome logic kept and single-sourced via exported getDispatchSummary); tests ported and extended.

🧪 Verification steps

⚙️ Environment Setup

Enable Alerting v2 in kibana.dev.yml:

xpack.alerting_v2.enabled: true

Then create at least one action policy, or open Stack Management > Alerts (v2) > Action policies > Create.

✅ Happy Path

  1. Open the Action Policy create form. Confirm each section (Policy details, Policy scope, Notification controls, Destination) renders as a described form group with the description on the left and fields on the right, separated by dividers.
  2. In Notification controls, confirm the left column shows the "Notification summary" panel with the mode description and the outcome sentence, and no helper text remains under "Notify per".
  3. Switch "Notify per" between Episode / Group / Digest and confirm the summary updates live (mode description + outcome).
  4. Hover (or click, or tab to) the info icon next to "Frequency". Confirm a light popover lists all frequency options for the current mode, each with its explanation, and that no helper text remains under the Frequency select.
  5. Save the policy and confirm it persists as before (defaults and validation unchanged).

⚡️ Edge Cases

  • Group mode with no group-by field selected: the summary prompts to select a field.
  • Repeat interval field appears only for strategies that need it; validation still fires.
  • Frequency popover content differs between per-episode and aggregate (Group/Digest) modes.
  • Verify in both classic and solution views.

⏪ Backport rationale

Pre-GA, feature-flagged Alerting v2 work — not backporting.

🔗 References

Relates to https://github.com/elastic/rna-program/issues/1050 (cross-repo; does not auto-close).

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown
🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!
  • Click to trigger kibana-entity-store-performance-from-pr for this PR!
  • Click to trigger kibana-storybooks-from-pr for this PR!

@miguelmartin-elastic miguelmartin-elastic changed the title Feat/restructure action policy form described groups 1050 [Alerting V2] Restructure Action Policy form with described form groups and progressive disclosure Sep 14, 2026
@miguelmartin-elastic miguelmartin-elastic added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Sep 14, 2026
@miguelmartin-elastic
miguelmartin-elastic marked this pull request as ready for review September 14, 2026 15:13
@miguelmartin-elastic
miguelmartin-elastic requested a review from a team as a code owner September 14, 2026 15:13
@kibanamachine

Copy link
Copy Markdown
Contributor

PR size reminder

This PR has 543 added lines of reviewable code, which is above the 500-line guideline for Nightshift PRs.

Large PRs get significantly less review engagement and take longer to merge. Consider splitting this into smaller, focused PRs before requesting review.

@kibanamachine

kibanamachine commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants