[Alerting V2] Restructure Action Policy form with described form groups and progressive disclosure - #290907
Open
miguelmartin-elastic wants to merge 6 commits into
Conversation
…structure-action-policy-form-described-groups-1050
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
miguelmartin-elastic
marked this pull request as ready for review
September 14, 2026 15:13
Contributor
PR size reminderThis PR has 543 added lines of reviewable code, which is above the 500-line guideline for Nightshift PRs. Large PRs get significantly less review engagement and take longer to merge. Consider splitting this into smaller, focused PRs before requesting review. |
Contributor
⏳ Build in-progress, with failures
Failed CI StepsHistory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Summary
Important
Alerting v2 work under a feature flag disabled by default. See Verification steps > Environment Setup.
Screen.Recording.2026-09-14.at.16.10.33.mov
Screen.Recording.2026-09-14.at.16.11.10.mov
Restructures the Action Policy create/edit form so explanatory copy no longer sits in the same visual path as the controls. The four sections now use
EuiDescribedFormGroup(description on the left, fields on the right), the Notification controls section shows a live summary on the left, and the Frequency helper text moves into an info-icon popover. Layout / progressive-disclosure only — no schema, dispatch, or API behavior changes.Changes
EuiSplitPanels toEuiDescribedFormGroup, with horizontal dividers between them.NotificationSummarycomponent: it reads form state viauseWatchand shows the selected notify-per mode description plus the resulting outcome. Removed from below the fields.FrequencyHelpTip,EuiPopover— opens on hover, click, and keyboard focus).dispatch_config_summary.tsx→notification_summary.tsx(outcome logic kept and single-sourced via exportedgetDispatchSummary); tests ported and extended.🧪 Verification steps
⚙️ Environment Setup
Enable Alerting v2 in
kibana.dev.yml:Then create at least one action policy, or open Stack Management > Alerts (v2) > Action policies > Create.
✅ Happy Path
⚡️ Edge Cases
⏪ Backport rationale
Pre-GA, feature-flagged Alerting v2 work — not backporting.
🔗 References
Relates to https://github.com/elastic/rna-program/issues/1050 (cross-repo; does not auto-close).