[Scout] Add loginAsEndpointPolicyManager browserAuth helper - #290726
Draft
MadameSheema wants to merge 1 commit into
Draft
[Scout] Add loginAsEndpointPolicyManager browserAuth helper#290726MadameSheema wants to merge 1 commit into
MadameSheema wants to merge 1 commit into
Conversation
Named convenience method matches loginAsT1Analyst so EDR artifact tests do not pass a string role name to loginAsSecurityRole. Co-authored-by: Cursor <cursoragent@cursor.com>
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Contributor
💛 Build succeeded, but was flaky
Failed CI Steps
Metrics [docs]
Test Failures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the review request on #289903 (comment).
browserAuth.loginAsEndpointPolicyManager()next tologinAsT1Analyst()/loginAsPlatformEngineer().loginAsSecurityRole('endpoint_policy_manager')caller onmain(three logins indescribeArtifactTabPolicyDetails).loginAsSecurityRole()remains for roles that do not have a named helper yet (rule_author,soc_manager).Relates to #289903.
Note
#289903 is still open and adds
artifact_list_suite.tswith the old string login. That file is not onmainyet. After this lands, that factory should switch tologinAsEndpointPolicyManager()— the generic method still works until then.Test plan
node scripts/type_check --project x-pack/solutions/security/packages/kbn-scout-security/tsconfig.jsonloginAsSecurityRole('endpoint_policy_manager')on this branchartifact_list_suite.tsif that PR is still openMade with Cursor