[Flyout Template] Improve meta-block truncation - #289147
Merged
tsullivan merged 5 commits intoSep 11, 2026
Merged
Conversation
tsullivan
added
release_note:skip
tsullivan
marked this pull request as ready for review
September 3, 2026 21:23
Dosant
self-requested a review
September 8, 2026 14:49
Dosant
approved these changes
Sep 8, 2026
Dosant
left a comment
Dosant
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall. I left two follow-up comments around link rendering and sizing.
| {truncatableText !== undefined ? ( | ||
| <span css={memoized.truncatedValue}> | ||
| <span css={memoized.fullTextSizer} aria-hidden> | ||
| {item.value} |
Contributor
There was a problem hiding this comment.
Could we render truncatableText in the sizing copy instead? Rendering item.value here and cloning it into the overlay mounts the link twice. That can duplicate refs, IDs, data-test-subj values, and component behavior.
| * zero width inside a shrink-to-fit parent. | ||
| */ | ||
| const isLinkElement = (value: ReactNode): value is ReactElement<{ children?: ReactNode }> => | ||
| isValidElement(value) && (value.type === EuiLink || value.type === 'a'); |
Contributor
There was a problem hiding this comment.
EuiLink does not always render an anchor: without a valid href, it renders a button. That button is shrink-to-fit and would contain the block-level EuiTextTruncate, so this path can hit the same layout failure described above. Can we restrict this to EuiLink instances guaranteed to render an anchor, or handle the button variant separately?
tsullivan
enabled auto-merge (squash)
September 11, 2026 17:28
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Unknown metric groupswarm start memory
Test Failures
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Truncation polish for https://github.com/elastic/kibana-team/issues/3165
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.