[EuiToolTip] Replace all title attributes with EuiToolTip#9643
Draft
weronikaolejniczak wants to merge 1 commit intoelastic:mainfrom
Draft
[EuiToolTip] Replace all title attributes with EuiToolTip#9643weronikaolejniczak wants to merge 1 commit intoelastic:mainfrom
weronikaolejniczak wants to merge 1 commit intoelastic:mainfrom
Conversation
weronikaolejniczak
force-pushed
the
feat/replace-title
branch
2 times, most recently
from
c0ed52f to
0ad67e1
Compare
weronikaolejniczak
force-pushed
the
feat/replace-title
branch
from
0ad67e1 to
5a469df
Compare
Collaborator
💚 Build SucceededHistory
|
Collaborator
💔 Build Failed
Failed CI StepsHistory
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
titleHTML attribute cases withEuiToolTip.EuiBetaBadgein favor of: [EuiBetaBadge] Deprecate the component #9343API Changes
N/A
Screenshots
EuiAvatar(Storybook)Hover an avatar with a
nameprop to see the name as a tooltip.EuiBadge(Storybook)Hover a badge to see its text as a tooltip; hover the close (x) icon to see its
iconOnClickAriaLabel.EuiBasicTable(Storybook)Hover truncated column headers, the select-all / row-select checkboxes, row action icons (especially disabled ones), and pagination arrows.
EuiBreadcrumbs(Storybook)Hover a truncated breadcrumb or the "See collapsed breadcrumbs" (...) toggle.
EuiButtonGroup(Storybook)Hover any icon-only button. Its label is now shown with
EuiToolTiponly (no duplicate browser tooltip).EuiComboBox(Storybook)Hover a selected pill in the input or any option in the dropdown list.
EuiDataGrid(Storybook)Hover truncated column headers, the column-actions (...) button, and in-cell action buttons (including the popover-trigger one).
EuiAutoRefresh(Storybook)Hover the refresh interval-unit selector / auto-refresh button.
EuiSuperDatePicker(Storybook)Hover the start / end date display buttons, the absolute tab date input, and the quick-select tabs.
EuiFacetButton(Storybook)Hover a facet button when its label is truncated.
EuiFilterButton(Storybook)Hover a filter button label when truncated.
EuiFieldPassword(Storybook)Hover the show / hide-password (eye) button next to the input.
EuiRange(Storybook)Hover a tick label on the range / dual-range slider.
EuiInlineEditText(Storybook)Hover the read-mode button when its text is truncated.
EuiInlineEditTitle(Storybook)Hover the read-mode button when its title text is truncated.
EuiListGroupItem(Storybook)Hover a list group item label when truncated.
EuiMarkdownEditor(Storybook)Hover the help (?) button in the editor footer.
EuiPagination(Storybook)Hover the previous / next (and first / last, when shown) arrow buttons.
EuiSearchBar(Storybook)Hover the search input and any filter buttons (
is, toggle, toggle-group).EuiSelectable(Storybook)Hover an option in the selectable list.
EuiSideNav(Storybook)Hover a side nav item when
truncateis enabled and the label overflows.EuiTable(Storybook)Hover a column header cell. Its tooltip shows the truncated label.
EuiTextTruncate(Storybook)Hover the rendered text. Tooltip should appear only when the text is actually truncated.
Impact Assessment
Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.
Impact level: 🟡 Moderate
Kibana PR: WIP
Release Readiness
Figma: {link to Figma or issue}Adoption plan (new features): {link to issue/doc or outline who will integrate this and where}QA instructions for reviewer
Test these components in Storybook:
EuiAvatar(Storybook, Docs)EuiToolTipEuiBadge(Storybook, Docs)EuiToolTipEuiBasicTable(Storybook, Docs)EuiToolTipEuiBreadcrumbs(Storybook, Docs)EuiToolTipEuiButtonGroup(Storybook, Docs)EuiToolTipEuiComboBox(Storybook, Docs)EuiToolTipEuiDataGrid(Storybook, Docs)EuiToolTipEuiAutoRefresh(Storybook, Docs)EuiToolTipEuiSuperDatePicker(Storybook, Docs)EuiToolTipEuiFacetButton(Storybook, Docs)EuiToolTipEuiFilterButton(Storybook, Docs)EuiToolTipEuiFieldPassword(Storybook, Docs)EuiToolTipEuiRange(Storybook, Docs)EuiToolTipEuiInlineEditText(Storybook, Docs)EuiToolTipEuiInlineEditTitle(Storybook, Docs)EuiToolTipEuiListGroupItem(Storybook, Docs)EuiToolTipEuiMarkdownEditor(Storybook, Docs)EuiToolTipEuiPagination(Storybook, Docs)EuiToolTipEuiSearchBar(Storybook, Docs)EuiToolTipEuiSelectable(Storybook, Docs)EuiToolTipEuiSideNav(Storybook, Docs)EuiToolTipEuiTable(Storybook, Docs)EuiToolTipEuiTextTruncate(Storybook, Docs)EuiToolTipChecklist before marking Ready for Review
Cypress, and VRTBreaking changes: Addedbreaking changelabel (if applicable)Reviewer checklist