-
Notifications
You must be signed in to change notification settings - Fork 873
refactor(EuiCopy): migrate from class to function component #9608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abhijnyan-codes
wants to merge
2
commits into
elastic:main
Choose a base branch
from
abhijnyan-codes:fix/eui-copy-class-to-function
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−45
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,83 +6,49 @@ | |
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| import React, { Component, ReactElement, ReactNode } from 'react'; | ||
| import React, { ReactElement, ReactNode, useState } from 'react'; | ||
| import { CommonProps } from '../common'; | ||
| import { copyToClipboard } from '../../services'; | ||
| import { EuiToolTip, EuiToolTipProps } from '../tool_tip'; | ||
|
|
||
| export interface EuiCopyProps extends CommonProps { | ||
| /** | ||
| * Text that will be copied to clipboard when copy function is executed. | ||
| */ | ||
| textToCopy: string; | ||
| /** | ||
| * Tooltip message displayed before copy function is called. | ||
| */ | ||
| beforeMessage?: ReactNode; | ||
| /** | ||
| * Tooltip message displayed after copy function is called that lets the user know that | ||
| * 'textToCopy' has been copied to the clipboard. | ||
| */ | ||
| afterMessage?: ReactNode; | ||
| /** | ||
| * Function that must return a component. First argument is 'copy' function. | ||
| * Use your own logic to create the component that users interact with when triggering copy. | ||
| */ | ||
| children(copy: () => void): ReactElement; | ||
| /** | ||
| * Optional props to pass to the EuiToolTip component. | ||
| */ | ||
| tooltipProps?: Partial< | ||
| Omit<EuiToolTipProps, 'children' | 'content' | 'onMouseOut'> | ||
| >; | ||
| } | ||
|
|
||
| interface EuiCopyState { | ||
| tooltipText: ReactNode; | ||
| } | ||
|
|
||
| export class EuiCopy extends Component<EuiCopyProps, EuiCopyState> { | ||
| static defaultProps = { | ||
| afterMessage: 'Copied', | ||
| }; | ||
|
|
||
| constructor(props: EuiCopyProps) { | ||
| super(props); | ||
|
|
||
| this.state = { | ||
| tooltipText: this.props.beforeMessage, | ||
| }; | ||
| } | ||
|
|
||
| copy = () => { | ||
| const isCopied = copyToClipboard(this.props.textToCopy); | ||
| export const EuiCopy = ({ | ||
| textToCopy, | ||
| beforeMessage, | ||
| afterMessage = 'Copied', | ||
| children, | ||
| tooltipProps, | ||
| }: EuiCopyProps) => { | ||
| const [tooltipText, setTooltipText] = useState<ReactNode>(beforeMessage); | ||
|
|
||
| const copy = () => { | ||
| const isCopied = copyToClipboard(textToCopy); | ||
| if (isCopied) { | ||
| this.setState({ | ||
| tooltipText: this.props.afterMessage, | ||
| }); | ||
| setTooltipText(afterMessage); | ||
| } | ||
| }; | ||
|
|
||
| resetTooltipText = () => { | ||
| this.setState({ | ||
| tooltipText: this.props.beforeMessage, | ||
| }); | ||
| const resetTooltipText = () => { | ||
| setTooltipText(beforeMessage); | ||
| }; | ||
|
weronikaolejniczak marked this conversation as resolved.
Outdated
|
||
|
|
||
| render() { | ||
| const { children, tooltipProps } = this.props; | ||
|
|
||
| return ( | ||
| // See `src/components/tool_tip/tool_tip.js` for explanation of below eslint-disable | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @abhijnyan-codes we do need this comment by the
Let's please bring it back 🙏🏻 |
||
| // eslint-disable-next-line jsx-a11y/mouse-events-have-key-events | ||
| <EuiToolTip | ||
| content={this.state.tooltipText} | ||
| onMouseOut={this.resetTooltipText} | ||
| {...tooltipProps} | ||
| > | ||
| {children(this.copy)} | ||
| </EuiToolTip> | ||
| ); | ||
| } | ||
| } | ||
| return ( | ||
| // eslint-disable-next-line jsx-a11y/mouse-events-have-key-events | ||
| <EuiToolTip | ||
| content={tooltipText} | ||
| onMouseOut={resetTooltipText} | ||
| {...tooltipProps} | ||
| > | ||
| {children(copy)} | ||
| </EuiToolTip> | ||
| ); | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.