Skip to content

Refactor timeline calculation to avoid state mutation#48

Open
egeozcan wants to merge 1 commit into
masterfrom
fix-timeline-calculation-mutation-1714110012230771213
Open

Refactor timeline calculation to avoid state mutation#48
egeozcan wants to merge 1 commit into
masterfrom
fix-timeline-calculation-mutation-1714110012230771213

Conversation

@egeozcan

Copy link
Copy Markdown
Owner

This change addresses a refactoring request in `src/components/timeline.js`. Previously, `calculateColumns` would mutate `this.columns` directly, making it difficult to compare the new value with the old value before taking actions (like fetching new data). The calculation logic has been moved to a pure function pattern, and call sites now handle state updates and side effects only when necessary.

Key changes:

  1. Modified `calculateColumns`: It now strictly returns the calculated column count based on element width.
  2. Updated `init`: Explicitly assigns the result of `calculateColumns` to `this.columns`.
  3. Refined `ResizeObserver`: Uses `calculateColumns` to get the potential new column count, compares it with the current state, and only updates/re-fetches if there is a change.
  4. Added Unit Tests: Created `src/components/timeline.test.js` using Vitest/Bun to ensure the logic remains correct and respects boundaries.

PR created automatically by Jules for task 1714110012230771213 started by @egeozcan

- Refactored \`calculateColumns\` to return the value instead of updating \`this.columns\`.
- Updated \`init\` and \`ResizeObserver\` to perform explicit comparison and assignment.
- Added \`src/components/timeline.test.js\` to verify the fix and prevent regressions.

Co-authored-by: egeozcan <185294+egeozcan@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant