Skip to content

Handle server errors by returning non-zero status codes #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DrRataplan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle server errors by returning non-zero status codes #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56fb34a
fix(error-code): do not throw (but not catch) errors codes
DrRataplan May 19, 2026
bd38a6c
fix(generator): return non-zero status code when generate failed
DrRataplan May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export function initClient(options) {
baseURL: options.server,
jar: cookieJar,
withCredentials: true,
validateStatus: null
})
);
}
Expand Down
16 changes: 9 additions & 7 deletions src/lib/generator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export async function update(config, options, client, resolve = []) {
await loginUser(client, options);
} catch (error) {
console.error(error.message);
return;
process.exit(1);
}

let spinner = ora('Starting generator ...').start();
Expand All @@ -67,7 +67,7 @@ export async function update(config, options, client, resolve = []) {
if (generatorResponse.status !== 200) {
spinner.fail('Generator failed with error: ' + generatorResponse.status);
console.error(generatorResponse.data);
return;
process.exit(1);
}
spinner.stop();

Expand All @@ -79,15 +79,15 @@ export async function update(config, options, client, resolve = []) {
chalk.red('Update was blocked due to breaking changes, even with --confirm-breaking. Check server logs or response:'),
);
console.error(output);
return;
process.exit(1);
}
if (options.quiet) {
console.error(
chalk.red(
'Breaking profile changes were detected. Re-run with --confirm-breaking to proceed non-interactively, or omit --quiet to confirm interactively.',
),
);
return;
process.exit(1);
}
printBreakingChangeDetails(output);
const proceed = await confirm({
Expand All @@ -104,13 +104,15 @@ export async function update(config, options, client, resolve = []) {
if (generatorResponse.status !== 200) {
console.error(chalk.red('Generator failed with error: ' + generatorResponse.status));
console.error(generatorResponse.data);
return;
process.exit(1);

}
output = generatorResponse.data;
if (isGeneratorBlockedByBreakingChanges(output)) {
console.error(chalk.red('Update is still blocked after confirmation. Server response:'));
console.error(output);
return;
process.exit(1);

}
}

Expand Down Expand Up @@ -187,7 +189,7 @@ export async function update(config, options, client, resolve = []) {
if (deployResponse.status !== 200) {
spinner.fail('Deploy failed with code ' + deployResponse.status + ': ' + deployResponse.data);
console.error('Deploy failed:', deployResponse.status, deployResponse.data);
return;
process.exit(1);
}
spinner.stop();
console.log(chalk.green('Done!'));
Expand Down