Skip to content

fix: TypeError on creating properties on immutable objects #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
novikovfred wants to merge 5 commits into
base: main
Choose a base branch
from
+27 −1
Open

fix: TypeError on creating properties on immutable objects #671

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11fab87
fix: type error, cannot create property
novikovfred Jun 7, 2024
a5d570e
Empty-Commit
novikovfred Jun 7, 2024
47437e4
fix: type error, cannot create property
novikovfred Jun 7, 2024
85f85dd
fix: type error, cannot create property
novikovfred Jun 7, 2024
69395d2
Merge pull request #1 from novikovfred/fix_typeerror
novikovfred Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion packages/conform-dom/formdata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,37 @@ export function setValue(
: {}
: valueFn(pointer[key]);

pointer[key] = newValue;
if (canAddProperty(pointer, key)) {
pointer[key] = newValue;
}
pointer = pointer[key];
}
}

function canAddProperty(
obj: Object | Array<unknown>,
property: string | number,
): boolean {
const propertyStr =
typeof property === 'number' ? property.toString() : property;
if (Object.prototype.hasOwnProperty.call(obj, propertyStr)) {
const descriptor = Object.getOwnPropertyDescriptor(obj, propertyStr);
if (descriptor && !descriptor.writable) {
return false;
}
}
if (!Object.isExtensible(obj)) {
return false;
}
if (Object.isSealed(obj) && !(propertyStr in obj)) {
return false;
}
if (Object.isFrozen(obj) && !(propertyStr in obj)) {
return false;
}
return true;
}

/**
* Retrive the value from a target object by following the paths
*/
Expand Down