test: unskip future APIs tests for specific browsers#1187
test: unskip future APIs tests for specific browsers#1187edmundhung wants to merge 1 commit intomainfrom
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThese changes update browser-specific test conditionals in conform-react's test suite. Previously skipped test cases for Firefox and WebKit are now executed unconditionally, with runtime guards selectively suppressing assertions for specific browsers rather than skipping entire tests. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying conform with
|
| Latest commit: |
5706b35
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cafce469.conform.pages.dev |
| Branch Preview URL: | https://fix-future-api-browser-tests.conform.pages.dev |
More templates
@conform-to/dom
@conform-to/react
@conform-to/valibot
@conform-to/validitystate
@conform-to/yup
@conform-to/zod
commit: |
Generated Summary
Changes Summary
useControl.browser.test.tsx
serverimport fromvitest/browserit.skipIf(server.browser === 'firefox')to an unconditionalit(), removing Firefox-specific gatinguseForm.browser.test.tsx
test.skipIf(server.browser === 'webkit' || server.browser === 'firefox')to unconditionaltest()callsconst shouldAssertCheckboxBlurError = server.browser !== 'webkit'if (shouldAssertCheckboxBlurError)) across both "shouldValidate: onBlur" and "shouldValidate: onBlur / shouldRevalidate: onInput" tests, while keeping text/description field assertions unconditionalThis shift from compile-time test skipping to runtime assertion filtering allows these tests to run across all browsers while accommodating WebKit's different checkbox interaction behavior.