Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

terraform: make GCP SA id optional#3777

Merged
msanft merged 1 commit intomainfrom
msanft/terraform/fix-gcp
Apr 22, 2025
Merged

terraform: make GCP SA id optional#3777
msanft merged 1 commit intomainfrom
msanft/terraform/fix-gcp

Conversation

@msanft
Copy link
Copy Markdown
Member

@msanft msanft commented Apr 22, 2025

Context

#3656 missed to add a default value for the service_account_id when removing / deprecating it. This caused a bug in the E2E test.

Proposed change(s)

  • Add a default value to the variable, which makes it optional.

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@msanft msanft added the no changelog Change won't be listed in release changelog label Apr 22, 2025
@msanft msanft added this to the v2.23.0 milestone Apr 22, 2025
@msanft msanft requested a review from thomasten April 22, 2025 07:33
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 22, 2025

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit fe2605e
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/680746502c998a0008ffa3de

@msanft msanft merged commit 81952fa into main Apr 22, 2025
8 checks passed
@msanft msanft deleted the msanft/terraform/fix-gcp branch April 22, 2025 07:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no changelog Change won't be listed in release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants