Fix generic method instantiation#46
Open
fcurdi wants to merge 3 commits intoedgardozoppi:metadata-providerfrom
Open
Fix generic method instantiation#46fcurdi wants to merge 3 commits intoedgardozoppi:metadata-providerfrom
fcurdi wants to merge 3 commits intoedgardozoppi:metadata-providerfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When obtaining an instantiated generic method reference, a method (M1) is obtained from a
MethodSpecificationHandleand then instantiated using theinstantiate()method present in the model. The issue is that the M1 might have not been extracted/processed yet, so when that happens a method that is not complete is used instead (i.e with some null fields). Theinstantiate()method uses M1 fields, which some of them are null, and set them to the new Instantiated method. Since this are fields, when M1 is actually processed and updated this does not translate to the instantiated method.A proxy is used instead to link the instantiation to M1 so when this last one is processed, the instantiation is updated as well.
This depends on #44.