Remove PDB#45
Open
fcurdi wants to merge 1 commit intoedgardozoppi:metadata-providerfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDB file is read just to determine local variables names. It is optional and even when present, not all variables have a name in the PDB file. So currently the result is a mix of real cil variable names and some generated ones for the non present names (local_$index). Besides this, cil allows multiple local variables with the same name. This change removes PDB reading to solve this last case, to unify variable names and so it is not necessary to provide the PDB file. Alternatively we can solve the name issue by assigning unique names to the ones that are duplicate. But i don't really see the point in reading the PDB optionally as it is now.