feat: add pull-to-refresh to Discover and Library Browse#1528
Open
RyanTheTechMan wants to merge 2 commits into
Open
feat: add pull-to-refresh to Discover and Library Browse#1528RyanTheTechMan wants to merge 2 commits into
RyanTheTechMan wants to merge 2 commits into
Conversation
Ordinary navigation back to Home continues to use the lightweight refresh behavior introduced in edde746#53.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a shared pull-to-refresh wrapper that works for both touch drags and desktop trackpad pan/zoom gestures, then wires it into the Discover screen and Library browsing flows (including the “folders” grouping) while adding coverage to ensure Discover refresh triggers via trackpad input.
Changes:
- Add
AppRefreshIndicator, a reusable widget that can triggerRefreshIndicatorvia trackpad pan/zoom when starting at the top of a scroll view. - Enable pull-to-refresh on Discover and library browse surfaces by wrapping their primary scroll views and ensuring always-scrollable physics where needed.
- Extend the Discover screen test to validate refresh-on-trackpad-pull behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/screens/discover_screen_test.dart | Adds a trackpad pan/zoom-driven refresh assertion for Discover. |
| lib/widgets/app_refresh_indicator.dart | New shared refresh wrapper supporting trackpad-triggered refresh. |
| lib/screens/libraries/tabs/library_browse_tab.dart | Wraps the browse scroll view in the shared refresh behavior and routes refresh to folder-tree vs. browse loader depending on grouping. |
| lib/screens/libraries/tabs/base_library_tab.dart | Replaces RefreshIndicator with the shared AppRefreshIndicator for library tabs using the base implementation. |
| lib/screens/discover_screen.dart | Wraps Discover’s main CustomScrollView with the shared refresh behavior and adds always-scrollable physics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added pull-to-refresh behavior to Discover and Library tabs on touch devices and desktop trackpads.
Changes