Skip to content

feat(libraries): show item count in browse toolbar #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RyanTheTechMan wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −2
Open

feat(libraries): show item count in browse toolbar #1516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions lib/screens/libraries/tabs/library_browse_tab.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1671,8 +1671,13 @@ class _LibraryBrowseTabState extends BaseLibraryTabState<MediaItem, LibraryBrows
/// Whether the sort chip is visible
bool get _isSortChipVisible => _sortOptions.isNotEmpty && _selectedGrouping != 'folders';

/// Whether the current browse result count is ready to display.
bool get _isItemCountVisible => !isLoading && errorMessage == null;

Comment thread
RyanTheTechMan marked this conversation as resolved.
/// Builds the chips bar widget
Widget _buildChipsBar() {
final theme = Theme.of(context);
final itemCountText = totalSize.toString();
VoidCallback? groupingNavigateRight;
if (_isFiltersChipVisible) {
groupingNavigateRight = () => _filtersChipFocusNode.requestFocus();
Expand All @@ -1681,7 +1686,7 @@ class _LibraryBrowseTabState extends BaseLibraryTabState<MediaItem, LibraryBrows
}

return Container(
color: Theme.of(context).scaffoldBackgroundColor,
color: theme.scaffoldBackgroundColor,
padding: const EdgeInsets.symmetric(horizontal: 16),
alignment: .centerLeft,
child: Row(
Expand All @@ -1699,7 +1704,7 @@ class _LibraryBrowseTabState extends BaseLibraryTabState<MediaItem, LibraryBrows
onNavigateRight: groupingNavigateRight,
onBack: widget.onBack,
),
const SizedBox(width: 8),
if (_isFiltersChipVisible || _isSortChipVisible) const SizedBox(width: 8),
// Filters chip
if (_isFiltersChipVisible)
FocusableFilterChip(
Expand Down Expand Up @@ -1730,6 +1735,19 @@ class _LibraryBrowseTabState extends BaseLibraryTabState<MediaItem, LibraryBrows
: () => _groupingChipFocusNode.requestFocus(),
onBack: widget.onBack,
),
if (_isItemCountVisible) ...[
const SizedBox(width: 12),
Semantics(
key: const ValueKey('library_browse_item_count'),
label: t.libraries.content,
value: itemCountText,
excludeSemantics: true,
child: Text(
itemCountText,
style: theme.textTheme.labelMedium?.copyWith(color: theme.colorScheme.onSurfaceVariant),
),
),
],
],
),
);
Expand Down