Skip to content

feat: add quality selection for Plex transcoded downloads #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
huzama wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add quality selection for Plex transcoded downloads #1418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion lib/database/app_database.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class AppDatabase extends _$AppDatabase {
AppDatabase.forTesting(super.e);

@override
int get schemaVersion => 16;
int get schemaVersion => 17;

@override
MigrationStrategy get migration {
Expand Down Expand Up @@ -221,6 +221,17 @@ class AppDatabase extends _$AppDatabase {
() => m.addColumn(syncRules, syncRules.includeSpecials),
);
}
if (from < 17) {
appLogger.i('Adding downloadQuality columns to DownloadedMedia and SyncRules (v17 migration)');
await _ignoreAlreadyExists(
'DownloadedMedia.downloadQuality column',
() => m.addColumn(downloadedMedia, downloadedMedia.downloadQuality),
);
await _ignoreAlreadyExists(
'SyncRules.downloadQuality column',
() => m.addColumn(syncRules, syncRules.downloadQuality),
);
}
},
);
}
Expand Down Expand Up @@ -540,6 +551,7 @@ class AppDatabase extends _$AppDatabase {
int mediaIndex = 0,
String downloadFilter = 'unwatched',
bool includeSpecials = true,
String? downloadQuality,
}) async {
// [insertOnConflictUpdate] defaults the conflict target to the primary
// key (`id`), which is auto-incremented — the conflict never triggers
Expand All @@ -558,6 +570,7 @@ class AppDatabase extends _$AppDatabase {
mediaIndex: Value(mediaIndex),
downloadFilter: Value(downloadFilter),
includeSpecials: Value(includeSpecials),
downloadQuality: Value(downloadQuality),
),
onConflict: DoUpdate(
(_) => SyncRulesCompanion(
Expand All @@ -569,6 +582,7 @@ class AppDatabase extends _$AppDatabase {
mediaIndex: Value(mediaIndex),
downloadFilter: Value(downloadFilter),
includeSpecials: Value(includeSpecials),
downloadQuality: Value(downloadQuality),
),
target: [syncRules.globalKey],
),
Expand Down
Loading