Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might add a sentence about OS-specific tests here. In case the test is OS-specific (fully qualified name contains "win32", "cocoa" or "gtk"), native tests must be enabled via
-DskipNativeTests=falseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this property needed? Why can't native tests always run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to admit that I don't know why it is currently configured like that. Maybe it's related to the Jenkins build, as that one does not execute any of the native tests at all. Without setting this properly, tests inside the OS-specific test bundles will not be executed. E.g., the command I mentioned in the review comment
mvn verify -Dtest=Test_org_eclipse_swt_events_KeyEvent -pl :org.eclipse.swt.tests.win32 - amwill not execute any test without-DskipNativeTests=false.