Skip to content

Fix SubMonitor misuse in UndoablePackageDeleteChange #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjohnstn merged 1 commit into from
May 14, 2026
+6 −8
Merged

Fix SubMonitor misuse in UndoablePackageDeleteChange #2985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions ...ring/org/eclipse/jdt/internal/corext/refactoring/changes/UndoablePackageDeleteChange.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,19 +39,17 @@ public UndoablePackageDeleteChange(String name, List<IResource> packageDeletes)
@Override
public Change perform(IProgressMonitor pm) throws CoreException {
int count= fPackageDeletes.size();
pm.beginTask("", count * 3); //$NON-NLS-1$
SubMonitor subMonitor= SubMonitor.convert(pm, count * 3);
List<IResourceSnapshot<IResource>> snapshots = new ArrayList<>();
for (int i= 0; i < fPackageDeletes.size(); i++) {
IResource resource= fPackageDeletes.get(i);
for (IResource resource : fPackageDeletes) {
snapshots.add(ResourceSnapshotFactory.fromResource(resource));
pm.worked(1);
subMonitor.split(1);
}

DynamicValidationStateChange result= (DynamicValidationStateChange) super.perform(SubMonitor.convert(pm, count));
DynamicValidationStateChange result= (DynamicValidationStateChange) super.perform(subMonitor.split(count));

for (int i= 0; i < fPackageDeletes.size(); i++) {
IResourceSnapshot<IResource> resourceDescription= snapshots.get(i);
resourceDescription.recordStateFromHistory(SubMonitor.convert(pm, 1));
for (IResourceSnapshot<IResource> resourceDescription : snapshots) {
resourceDescription.recordStateFromHistory(subMonitor.split(1));
result.add(new UndoDeleteResourceChange(resourceDescription));
}
return result;
Expand Down
Loading