Skip to content

Do not wait for AST when copying code in ClipboarOperationAction #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjohnstn merged 1 commit into from
Aug 14, 2025
Merged

Do not wait for AST when copying code in ClipboarOperationAction #2406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/ClipboardOperationAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,11 @@ private boolean isNonTrivialSelection(ITextSelection selection) {


private ClipboardData getClipboardData(ITypeRoot inputElement, int offset, int length) {
CompilationUnit astRoot= SharedASTProviderCore.getAST(inputElement, SharedASTProviderCore.WAIT_ACTIVE_ONLY, null);
// Since this call happens in the UI thread, pass WAIT_NO as parameter
// so that the call can not reach the wait call that causes UI freezes.
// The cost of doing so is that the method could return null from time
// to time and therefore the imports may not be copied to the clipboard
CompilationUnit astRoot= SharedASTProviderCore.getAST(inputElement, SharedASTProviderCore.WAIT_NO, null);
if (astRoot == null) {
return null;
}
Expand Down
Loading