Skip to content

Add environment variables and secrets#682

Closed
spoenemann wants to merge 2 commits into
eclipse-csi:mainfrom
spoenemann:environments
Closed

Add environment variables and secrets#682
spoenemann wants to merge 2 commits into
eclipse-csi:mainfrom
spoenemann:environments

Conversation

@spoenemann

Copy link
Copy Markdown
Contributor

Closes #537, closes #680.

  • New EnvironmentSecret/EnvironmentVariable model classes
  • Extended Environment with a repo_name bridging field, nested secrets/variables lists, get_model_objects, resolve_secrets/copy_secrets, and a generate_live_patch override that cascades to nested secrets/variables
  • New REST client methods for GET/PUT/DELETE environment secrets and GET/POST/PATCH/DELETE environment variables, plus facade wrappers
  • Repository.get_environment() helper and cascading resolve_secrets/copy_secrets
  • New JsonnetConfig entries/default-config properties, jsonnet template functions, and JSON schema files
  • Web UI resource registry entries
  • New unit tests plus new integration tests with extended ModelForContext test helper
  • Docs: New pages for environment variables/secrets

@heurtematte

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

At first glance, it seems that this PR may overlap with this one: #614

Could you clarify the main difference between the two approaches? besides the naming convention.

I'm currently reviewing the other one, maybe worth giving your opinion on this one.

@netomi

netomi commented Jul 8, 2026

Copy link
Copy Markdown
Member

there is also #641 which only adds support for prevent_self_review. We should keep PRs minimal to make it easier to review and test, I would be in favor of merging the other PR first and then update this accordingly.

Edit: I applied the same missing transformation for the new prevent_self_review field from this PR to the other one, added some additional validation and merged it after testing.

Signed-off-by: Thomas Neidhart <thomas.neidhart@eclipse-foundation.org>
@netomi netomi changed the title Add environment variables and secrets, add 'prevent self-review' Add environment variables and secrets Jul 8, 2026
@spoenemann

Copy link
Copy Markdown
Contributor Author

Ok sorry, I didn't see the previous PRs.

@spoenemann spoenemann closed this Jul 9, 2026
@netomi netomi reopened this Jul 11, 2026
@sonarqubecloud

Copy link
Copy Markdown

@netomi

netomi commented Jul 11, 2026

Copy link
Copy Markdown
Member

I tried to push some changes but it was not permitted, recreated the PR as #689.

The PR is very good and I would like to get this integrated as is with these slight modifications.

@netomi netomi closed this Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: Support environment secrets Request: Support "prevent self-review" for environments

3 participants