fix(xls): reset signal_name on frame boundary to prevent first signal…#911
Open
oikawa-yusuke wants to merge 1 commit into
Open
Conversation
… skip
When two consecutive frames share the same signal name as the
transition point (e.g. frame A ends with "position" and frame B
also starts with "position"), the duplicate-detection guard
if sh.cell(row_num, index['signalName']).value != signal_name
evaluated to False for the first signal of frame B, causing it to
be silently dropped from the output DBC.
Fix: reset signal_name to "" whenever a new frame is detected so
the first signal of every frame is always processed.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When two consecutive frames share the same signal name at the frame
boundary (e.g. frame A ends with "position" and frame B also starts
with "position"), the duplicate-detection guard
evaluates to False for the first signal of frame B, causing it to be
silently dropped from the output.
Fix
Reset
signal_nameto""whenever a new frame is detected so thefirst signal of every frame is always processed correctly.
Reproduction
Define two consecutive messages where the last signal of message A and
the first signal of message B have the same name. The first signal of
message B will be missing from the generated DBC.