Don't convert from phys to raw if BA_DEF_DEF_ "GenSigStartValue" is defined in DBC#910
Merged
Merged
Conversation
…efined in the dbc conversion of DBC BA_DEF_DEF_ "GenSigStartValue" will lead to wrong default value
…tvalue Don't convert from phys to raw if BA_DEF_DEF_ "GenSigStartValue" is defined in DBC
Contributor
Author
|
this PR should fix #908 |
Contributor
Author
|
@ebroecker LGTY? |
Owner
|
seems the tests fail. Either the tests are wrong, or your patch. |
Contributor
Author
|
@ebroecker I fixed the test test_default_initial_value() expected value , it should pass now |
Contributor
Author
|
@ebroecker LGTY? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conversion of DBC BA_DEF_DEF_ "GenSigStartValue" will lead to wrong default value