Skip to content

fix: short-circuit list_schemas to skip ~500x storm in before_run #9671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeff-dude merged 2 commits into from
May 14, 2026
+7 −7
Merged

fix: short-circuit list_schemas to skip ~500x storm in before_run #9671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b4187b
Short-circuit list_schemas to skip ~500x query storm in before_run
0xRobin May 14, 2026
6a403f2
Merge branch 'main' into fix/list-schemas-storm
jeff-dude May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dbt_macros/dune/no-relation-listing.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
{%- endmacro %}

{% macro list_schemas(database) -%}
{% do log(target) %}
{%- if (var('no-relation-listing', 'false').lower() == 'true') or (target.profile_name == 'spellbook-local') -%}
{{ return([]) }}
{%- else -%}
{{ return(adapter.dispatch('list_schemas')(database)) }}
{# Workaround for https://github.com/dbt-labs/dbt-adapters/issues/1929 -- drop once fixed. #}
{{ return([]) }}
{%- endif -%}
{%- endmacro %}

Expand Down
2 changes: 1 addition & 1 deletion dbt_macros/dune/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{%- if target.database == 'dune' -%}
CREATE SCHEMA IF NOT EXISTS {{ relation }}
{%- else -%}
CREATE SCHEMA {{ relation }} WITH (location = 's3a://{{s3_bucket()}}/')
CREATE SCHEMA IF NOT EXISTS {{ relation }} WITH (location = 's3a://{{s3_bucket()}}/')
{%- endif -%}
{% endcall %}
{% endmacro %}
4 changes: 2 additions & 2 deletions dbt_subprojects/tokens/models/_dev/tokens_dev_table.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
file_format = 'delta'
) }}

--stamp 1
select 1 as stamp
--stamp 2
select 2 as stamp
4 changes: 2 additions & 2 deletions dbt_subprojects/tokens/models/_dev/tokens_dev_view.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
materialized = 'view'
) }}

--stamp 1
select 1 as stamp
--stamp 2
select 2 as stamp
Loading