Security: fix deserialization, timing attack, open redirect, and name bug#55
Open
nicdavidson wants to merge 5 commits intodevelopfrom
Open
Security: fix deserialization, timing attack, open redirect, and name bug#55nicdavidson wants to merge 5 commits intodevelopfrom
nicdavidson wants to merge 5 commits intodevelopfrom
Conversation
Added standard overview describing DreamFactory as a secure, self-hosted enterprise data access platform for enterprise apps and on-prem LLMs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
… bug - Replace unserialize() with json_encode/json_decode for OAuth 1.0 temporary credentials (prevents RCE via cache poisoning) - Use hash_equals() for Heroku SSO token comparison (prevents timing attack) - Sanitize exception messages in OAuth redirect URLs (prevents info leak) - Default-deny redirect when no whitelist configured (prevents open redirect) - Fix || to ?: for user name extraction (was storing boolean "1" as name)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unserialize()withjson_encode/json_decodefor OAuth 1.0 temp credentials — prevents RCE via cache poisoninghash_equals()for Heroku SSO token comparison — prevents timing attack||to?:for user name extraction — was storing booleantrue("1") as the user's name in bothBaseOAuthServiceandGoogleserviceNot addressed (needs discussion)
is_sys_admin = true) — business logic decisionTest plan