Skip to content

Add device and output selection support#85

Open
bsneed wants to merge 20 commits into
doublesymmetry:mainfrom
bsneed:bsneed/output
Open

Add device and output selection support#85
bsneed wants to merge 20 commits into
doublesymmetry:mainfrom
bsneed:bsneed/output

Conversation

@bsneed

@bsneed bsneed commented Apr 11, 2024

Copy link
Copy Markdown
Contributor
  • Adds AudioDevice class.
  • Adds localDevices property to retrieve a list of visible audio output devices.
  • Adds outputDevice property to get / set the audio output device.
  • Fixed deadlock in AVPlayerWrapper where the delegate can issue a state change while still inside the lock.
  • Depends on Added AudioTap functionality #80

@codecov

codecov Bot commented Apr 11, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.70588% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.54%. Comparing base (4d3c1db) to head (8dd0a04).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/SwiftAudioEx/Utils/Devices.swift 69.72% 33 Missing ⚠️
Sources/SwiftAudioEx/AudioTap.swift 85.71% 7 Missing ⚠️
Sources/SwiftAudioEx/AudioItem.swift 0.00% 2 Missing ⚠️
Sources/SwiftAudioEx/AudioPlayer.swift 50.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (74.70%) is below the target coverage (78.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (77.54%) is below the target coverage (78.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   78.33%   77.54%   -0.80%     
==========================================
  Files          17       19       +2     
  Lines        1288     1456     +168     
==========================================
+ Hits         1009     1129     +120     
- Misses        279      327      +48     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant