Skip to content
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/Docfx.Dotnet/DotnetApiCatalog.cs
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,18 @@ internal static async Task Exec(MetadataJsonConfig config, DotnetApiOptions opti

EnvironmentContext.SetBaseDirectory(configDirectory);

// this is here because heading into Compile, MSBuildLocator must have been registered as it uses MSBuild APIs
if (!MSBuildLocator.IsRegistered)
{
var latestVersion = MSBuildLocator.QueryVisualStudioInstances().MaxBy(instance => instance.Version);
Comment thread
filzrev marked this conversation as resolved.
Outdated
if (latestVersion == null)
{
throw new InvalidOperationException("Failed to find a version of Visual Studio or .NET SDK installed");
}

MSBuildLocator.RegisterInstance(latestVersion);
Comment thread
dpvreony marked this conversation as resolved.
}

foreach (var item in config)
{
VisitorHelper.GlobalNamespaceId = item.GlobalNamespaceId;
Expand All @@ -85,15 +97,6 @@ internal static async Task Exec(MetadataJsonConfig config, DotnetApiOptions opti

async Task Build(ExtractMetadataConfig config, DotnetApiOptions options)
{
// this is here because heading into Compile, MSBuildLocator must have been registered as it uses MSBuild APIs
var latestVersion = MSBuildLocator.QueryVisualStudioInstances().MaxBy(instance => instance.Version);
if (latestVersion == null)
{
throw new InvalidOperationException("Failed to find a version of Visual Studio or .NET SDK installed");
}

MSBuildLocator.RegisterInstance(latestVersion);

var assemblies = await Compile(config);

switch (config.OutputFormat)
Expand Down