Update building.md with 'make' command#274
Update building.md with 'make' command#274Sawsqr68 wants to merge 2 commits intodocbook:bobs_bugfix_branchfrom
Conversation
Add missing 'make' command to the build instructions.
There was a problem hiding this comment.
Pull request overview
This PR attempts to add a missing make command to the build instructions in building.md. However, the change introduces a duplicate command that already exists in the "Building" section (line 15) and places it at the end of the "Packaging" section without proper context or formatting.
Key Issues
- The
makecommand is already documented in the "Building" section, making this addition redundant - The new command lacks proper formatting (missing backticks and indentation)
- A trailing space exists after the command
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| `make dist` | ||
|
|
||
| make |
There was a problem hiding this comment.
The added make command lacks proper formatting. Throughout the document, commands are formatted as inline code blocks using backticks and are indented with two spaces. This line should be formatted as \make`` to maintain consistency with lines 15, 26, and 34.
| make | |
| `make` |
There was a problem hiding this comment.
makeالأمر موثق مسبقًا في السطر 15 ضمن
|
|
||
| `make dist` | ||
|
|
||
| make |
There was a problem hiding this comment.
This command appears to be placed in the wrong section. The make command is already documented on line 15 under the "Building" section. This duplicate entry at the end of the "Packaging" section doesn't make sense contextually. Consider removing this line or clarifying what additional build step is needed here.
| make |
|
|
||
| `make dist` | ||
|
|
||
| make |
There was a problem hiding this comment.
There is a trailing space after make on this line. This should be removed to maintain clean formatting.
| make | |
| make |
This reverts commit 7d902c9
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Add missing 'make' command to the build instructions.