Skip to content

Update building.md with 'make' command#274

Open
Sawsqr68 wants to merge 2 commits intodocbook:bobs_bugfix_branchfrom
Sawsqr68:patch-1
Open

Update building.md with 'make' command#274
Sawsqr68 wants to merge 2 commits intodocbook:bobs_bugfix_branchfrom
Sawsqr68:patch-1

Conversation

@Sawsqr68
Copy link
Copy Markdown

@Sawsqr68 Sawsqr68 commented Dec 7, 2025

Add missing 'make' command to the build instructions.

Add missing 'make' command to the build instructions.
Copilot AI review requested due to automatic review settings December 7, 2025 08:39
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to add a missing make command to the build instructions in building.md. However, the change introduces a duplicate command that already exists in the "Building" section (line 15) and places it at the end of the "Packaging" section without proper context or formatting.

Key Issues

  • The make command is already documented in the "Building" section, making this addition redundant
  • The new command lacks proper formatting (missing backticks and indentation)
  • A trailing space exists after the command

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread building.md Outdated

`make dist`

make
Copy link

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added make command lacks proper formatting. Throughout the document, commands are formatted as inline code blocks using backticks and are indented with two spaces. This line should be formatted as \make`` to maintain consistency with lines 15, 26, and 34.

Suggested change
make
`make`

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot اصنع

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makeالأمر موثق مسبقًا في السطر 15 ضمن

Comment thread building.md Outdated

`make dist`

make
Copy link

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command appears to be placed in the wrong section. The make command is already documented on line 15 under the "Building" section. This duplicate entry at the end of the "Packaging" section doesn't make sense contextually. Consider removing this line or clarifying what additional build step is needed here.

Suggested change
make

Copilot uses AI. Check for mistakes.
Comment thread building.md Outdated

`make dist`

make
Copy link

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a trailing space after make on this line. This should be removed to maintain clean formatting.

Suggested change
make
make

Copilot uses AI. Check for mistakes.
@Sawsqr68
Copy link
Copy Markdown
Author

Sawsqr68 commented Dec 7, 2025

@copilot open a new pull request to apply changes based on the comments in this thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants