Add attribute set for Unicode-character callouts#180
Open
tgraham-antenna wants to merge 5 commits intodocbook:masterfrom
Open
Add attribute set for Unicode-character callouts#180tgraham-antenna wants to merge 5 commits intodocbook:masterfrom
tgraham-antenna wants to merge 5 commits intodocbook:masterfrom
Conversation
bobstayton
requested changes
Jun 2, 2020
Contributor
bobstayton
left a comment
bobstayton
left a comment
There was a problem hiding this comment.
The changes to the XSL look fine (thanks for this new feature), but there are two problems that need to be corrected before merge.
- In addition to editing xsl/fo/param.ent, you must also edit xsl/fo/param.xweb to add an entry for your new attribute set.
- The list of file changes for the this PR shows that the reference page xsl/params/calloutlist.properties.xml was deleted. I suspect that was not intentional.
Contributor
Author
|
Only slightly thrashing around in the dark with 'git', but the changes should have been made. |
bobstayton
approved these changes
Jun 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to set the color of my callout labels.
I have no experience with making a
refentryfor an attribute set, and I created the file directly on GitHub, so hopefully it works well enough.