Added "A bug fixed" haiku#1030
Merged
ltagliaferri merged 2 commits intodo-community:masterfrom Oct 20, 2020
Merged
Conversation
Adding a new Haiku
Contributor
Author
|
Added a fix to the syllable library for this words/syllable#47 |
Contributor
|
Sorry about the testing issue, sometimes it is not quite right! Fixed the test here and am merging this in! Thanks for being a part of open source 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new Haiku.
The last line "an anxious silence" is five syllables but the "syllable" library incorrectly reads it as six. Looking at the library now to see if there's a way to fix it.
I was stumped a moment and checked online with a few sites to see if I'd be pronouncing it all wrong, but it looks like it's still five syllables
https://www.howmanysyllables.com/syllable_counter/
https://syllablecounter.net/count
http://www.syllablecount.com/syllables/