Handle corrupted Report.pkl gracefully in RetryManager to prevent component crash#12486
Open
Viphava280444 wants to merge 1 commit into
Open
Handle corrupted Report.pkl gracefully in RetryManager to prevent component crash#12486Viphava280444 wants to merge 1 commit into
Viphava280444 wants to merge 1 commit into
Conversation
Member
|
Hi @Viphava280444 this change is specific to Tier0 right? |
Member
|
test this please |
1 similar comment
Member
|
test this please |
Contributor
Author
Hi @hassan11196, |
Member
|
test this please |
|
Jenkins results:
|
Member
|
test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12414
Status
ready
Description
When PauseAlgo.isReady() fails to unpickle a corrupted Report.pkl, the exception crashes the entire RetryManagerPoller thread, blocking retries for all jobs in cooloff — not just the affected one.
This fix wraps the plugin.isReady() call in selectRetryAlgo() with a try/except so that pickle failures are logged as warnings and the job proceeds with retry (skipping exit code check) instead of crashing the component.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None