Add PoC creation for _User sites#1035
Conversation
Start with T2_IT_Rome. Hardcoded list of sites enabled, taking total rse limit from local_usage field in site capacity as agreed with Facilities for this tests
There was a problem hiding this comment.
Pull request overview
Adds initial support for creating and managing “_User” RSE variants (PoC starting with T2_IT_Rome) in the dockerized Rucio client tooling, and adjusts capacity/quota handling logic intended for these _User RSEs.
Changes:
- Add
--type usersupport and PoC site allowlist to create/update${RSE}_Uservariants from GitLabstorage.json. - Extend
CMSRSEto build_User-suffixed RSE names and add auserdomain configuration. - Adjust site capacity update logic to treat
_UserRSEs as having capacity driven bydisk_local_use.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docker/rucio_client/scripts/setSiteCapacity | Adds _User-specific static usage/quota logic for capacity updates. |
| docker/rucio_client/scripts/setRucioFromGitlab | Adds --type user mode and PoC allowlist to manage _User RSE variants. |
| docker/rucio_client/scripts/setOneRucioFromGitlab | Updates CLI help text to include the new user type. |
| docker/rucio_client/scripts/CMSRSE.py | Adds user handling for RSE naming and domain configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| rse = CMSRSE(site, dry=options.dry_run, cms_type=options.cms_type, deterministic=deterministic) | ||
| try: |
There was a problem hiding this comment.
@dciangot Isn't this a valid comment. We should set a default FTS if there is nothing there?
| rse = CMSRSE(site, dry=options.dry_run, cms_type=options.cms_type, deterministic=deterministic) | ||
| try: | ||
| if rse.update(): |
| rse_name = site['rse'] + '_User' | ||
| deterministic = True | ||
| if rse_name in SKIP_SITES or not DO_SITES or rse_name not in DO_SITES: | ||
| print(' Skipping.') | ||
| continue |
There was a problem hiding this comment.
This sounds valid too, like a catch-22
the logic of the cms_type=user is trickier than I thought. This should work as expected now
| rse = CMSRSE(site, dry=options.dry_run, cms_type=options.cms_type, deterministic=deterministic) | ||
| try: |
There was a problem hiding this comment.
@dciangot Isn't this a valid comment. We should set a default FTS if there is nothing there?
| rse_name = site['rse'] + '_User' | ||
| deterministic = True | ||
| if rse_name in SKIP_SITES or not DO_SITES or rse_name not in DO_SITES: | ||
| print(' Skipping.') | ||
| continue |
There was a problem hiding this comment.
This sounds valid too, like a catch-22
|
thanks @ericvaandering , I think that the comments should have been addressed by the last commit. |
Start with T2_IT_Rome. Hardcoded list of sites enabled, taking total rse limit from local_usage field in site capacity as agreed with Facilities for this tests