Validate unique column names in pandas.#12199
Merged
trivialfis merged 3 commits intodmlc:masterfrom May 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit validation step in the pandas DataFrame transformation path to reject duplicate column names early, preventing ambiguous feature handling when constructing XGBoost matrices from pandas inputs.
Changes:
- Reject pandas DataFrames with duplicate
data.columnsin_transform_pandas_df. - Raise a
ValueErrorwhen duplicates are detected.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+660
to
+661
| if data.columns.has_duplicates: | ||
| raise ValueError("Duplicate column names are not supported.") |
Member
Author
There was a problem hiding this comment.
@copilot apply changes based on this feedback
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.