Skip to content

build_all.d: Don't run makensis when NoVagrant #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibuclaw merged 1 commit into from
Mar 2, 2026
Merged

build_all.d: Don't run makensis when NoVagrant #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions create_dmd_release/build_all.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,18 +329,25 @@ void runBuild(ref Box box, string ver, bool isBranch, bool skipDocs, string ldcV
break;

case OS.windows:
with (box.shell())
version (NoVagrant)
{
// Migrated to GHA build_release_template.yml
}
else
{
cmd(`cd clones\installer\windows`);
cmd(`&'C:\Program Files (x86)\NSIS\makensis'`~
` '/DEmbedD2Dir=C:\Users\vagrant\dmd.`~ver~`.windows\dmd2'`~
` '/DVersion2=`~ver~`' d2-installer.nsi`);
cmd(`move dmd-`~ver~`.exe C:\Users\vagrant\dmd-`~ver~`.exe`);
// sign installer
version (CodeSign)
cmd(`&C:\Users\vagrant\codesign\sign.ps1 C:\Users\vagrant\codesign\win.pfx C:\Users\vagrant\codesign\win.fingerprint C:\Users\vagrant\codesign\win.pass C:\Users\vagrant\dmd-`~ver~`.exe`);
with (box.shell())
{
cmd(`cd clones\installer\windows`);
cmd(`&'C:\Program Files (x86)\NSIS\makensis'`~
` '/DEmbedD2Dir=C:\Users\vagrant\dmd.`~ver~`.windows\dmd2'`~
` '/DVersion2=`~ver~`' d2-installer.nsi`);
cmd(`move dmd-`~ver~`.exe C:\Users\vagrant\dmd-`~ver~`.exe`);
// sign installer
version (CodeSign)
cmd(`&C:\Users\vagrant\codesign\sign.ps1 C:\Users\vagrant\codesign\win.pfx C:\Users\vagrant\codesign\win.fingerprint C:\Users\vagrant\codesign\win.pass C:\Users\vagrant\dmd-`~ver~`.exe`);
}
box.scp("default:dmd-"~ver~".exe", "build/");
}
box.scp("default:dmd-"~ver~".exe", "build/");
break;

case OS.osx:
Expand Down
Loading