Make Opus support opt-in#2932
Closed
freya022 wants to merge 12 commits into
Closed
Conversation
9f96a66 to
ae7933e
Compare
33ef394 to
b6d6049
Compare
It used to say audio wasn't supported when a user loaded the library earlier
Supersedes discord-jda#2880
9f2d193 to
f730509
Compare
Contributor
Author
|
Superseded by #2997 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This PR moves the Opus encoder and decoder to a separate module, as well as the
opus-javaandJNAdependencies with it.This makes the Opus codec opt-in, as it was previously opt-out; and eliminates the
no-opusartifact.Future work may include:
This also fixes the
minartifact not excluding the "additional audio" dependencies