Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 16 16
Lines 758 758
=======================================
Hits 750 750
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug breaking the functionality of ExtendedTableOfContents with recent versions of PlutoUI.
This commit JuliaPluto/PlutoUI.jl@4fb2d5a (or someone close to it) changed some internals that broke how PlutoExtras was handling the ToC to add the extended functionality.
This PR makes the code handling the processing more robust and also refactors the code so that it's separated into a .js file (containing most of the scripts content), a .css file containing the style and a much reduced julia file which simply interpolated the JS and CSS code directly inside the
@htl("...")macro, leading to cleaner code that is much easier to reason about (especially thanks to proper code formatting in IDEs for the JS and CSS part).As part of this PR, I also fixed an issue with the
hide headingbutton that was going out of position when scrolling the notebook.I also tested again on firefox and I can't experince the issue in #28 in firefox, so this also fixes #28