Skip to content

[GECO-142] Ignoring files by non core components#117

Open
diya17 wants to merge 10 commits into
story/GECO-141from
bug/GECO-142
Open

[GECO-142] Ignoring files by non core components#117
diya17 wants to merge 10 commits into
story/GECO-141from
bug/GECO-142

Conversation

@diya17
Copy link
Copy Markdown
Contributor

@diya17 diya17 commented Jun 13, 2023

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

(you can copy the ticket if it hasn't changed)

...Put description here...

Anything else the reviewer needs to know?

... describe here; e.g. is there another pull request this pull request depends on? If so, link it here. ...

@diging-jenkins
Copy link
Copy Markdown

Can one of the admins verify this patch?

@diya17 diya17 marked this pull request as ready for review June 15, 2023 15:34
@diya17 diya17 requested a review from jdamerow June 15, 2023 15:34
@diya17 diya17 closed this Jun 15, 2023
@diya17 diya17 reopened this Jun 22, 2023
@diya17 diya17 closed this Jun 22, 2023
@diya17 diya17 reopened this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants