Skip to content

Story/GECO-141 : Changes to giles web to integrate with tardis#116

Open
diya17 wants to merge 19 commits into
developfrom
story/GECO-141
Open

Story/GECO-141 : Changes to giles web to integrate with tardis#116
diya17 wants to merge 19 commits into
developfrom
story/GECO-141

Conversation

@diya17
Copy link
Copy Markdown
Contributor

@diya17 diya17 commented May 19, 2023

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

I have added 2 properties to the storage request

  1. pageNr - pageNr is set so that we know the pageNr of the extracted image in the pdf when Tardis extracts the image.
  2. imageExtracted - imageExtracted is set so that an infinite loop is avoided when nepomuk sends a storage complete event and tardis listens to it.

Anything else the reviewer needs to know?

Needs the giles-eco-request PR to be merged first and version to be updated before merging this story
Giles shows each extracted file twice in the UI and that will be handled in another story.

@diging-jenkins
Copy link
Copy Markdown

Can one of the admins verify this patch?

@diya17 diya17 requested a review from jdamerow May 19, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants