Skip to content

minor fixes relating to python v >= 3.11#388

Merged
sapkotaruz11 merged 4 commits intodevelopfrom
query_gen_fix
Feb 26, 2026
Merged

minor fixes relating to python v >= 3.11#388
sapkotaruz11 merged 4 commits intodevelopfrom
query_gen_fix

Conversation

@sapkotaruz11
Copy link
Copy Markdown
Member

@sapkotaruz11 sapkotaruz11 commented Feb 23, 2026

This commit applies Python 3.11 (or greater) compatibility fixes in query_generator.py and run.py. It wraps random.sample(...) inputs with list(...) so sampling works with dict/set views, and corrects argparse/help-string escaping ("\s+" and x%%) to avoid parsing/formatting issues.

@sapkotaruz11 sapkotaruz11 changed the title minor fixes relating to python3.14 minor fixes relating to python v >= 3.11 Feb 23, 2026
@sapkotaruz11 sapkotaruz11 requested a review from Demirrr February 23, 2026 12:46
Copy link
Copy Markdown
Member

@Demirrr Demirrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

Comment thread dicee/scripts/run.py Outdated
@Demirrr Demirrr self-requested a review February 24, 2026 13:18
Comment thread dicee/scripts/run.py Outdated
choices=["pandas", "polars", "rdflib"],
help='Backend for loading, preprocessing, indexing input knowledge graph.')
parser.add_argument("--separator", type=str, default="\s+",
parser.add_argument("--separator", type=str, default="\\s+",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this line is changed :)

@sapkotaruz11 sapkotaruz11 merged commit 2b5f065 into develop Feb 26, 2026
3 checks passed
@sapkotaruz11 sapkotaruz11 deleted the query_gen_fix branch February 26, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants