fix(ci): pass mcp_server_origin in e2e frontend install args#4029
Merged
Conversation
The /mcp delegation flow is gated on the deploy-configured mcp_server_origin: when unset, getMcpServerOrigin() is undefined and every real request renders the invalid screen. The e2e job installs the frontend canister with inline --args (overriding the template), and that record omitted mcp_server_origin, so all interactive mcp.spec.ts tests hit the invalid screen and timed out (only the two invalid-request cases passed). Add mcp_server_origin = opt "https://mcp.id.ai" to match the origin the mcp fixture posts to. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0174RnuPSyzddg68qZBXYKE1
|
✅ No security or compliance issues detected. Reviewed everything up to 87242fc. Security Overview
Detected Code Changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why CI is failing on #4026
The e2e
e2e-playwrightjob (shard6_6, bothdesktopandmobile) failed: all 6 interactiveroutes/mcp.spec.tstests timed out (the 2 "Invalid request" cases passed).Root cause: the
/mcpflow is gated on the deploy-configuredmcp_server_origin. When unset,getMcpServerOrigin()isundefined, sorequestValidis alwaysfalseand every real request renders the Invalid request screen — which is exactly why the gated-screen / Allow-access tests never found their elements.The e2e job installs the frontend canister with inline
--args(overriding thelocal_test_arg.did.template, as the workflow comments note), and that inline record omittedmcp_server_origin. Themcpfixture posts tohttps://mcp.id.ai, so the canister must be deployed with that origin.Fix
Add
mcp_server_origin = opt "https://mcp.id.ai"to the frontend install--argsin.github/workflows/canister-tests.yml, matching the origin the fixture uses.This PR targets
feat/mcp-authorizeso the fix lands on #4026's branch.🤖 Generated with Claude Code
https://claude.ai/code/session_0174RnuPSyzddg68qZBXYKE1
Generated by Claude Code