Skip to content

Disable custom shadow painting for SeparatePanel on Wayland.#296

Open
gearonixx wants to merge 1 commit into
desktop-app:masterfrom
gearonixx:master
Open

Disable custom shadow painting for SeparatePanel on Wayland.#296
gearonixx wants to merge 1 commit into
desktop-app:masterfrom
gearonixx:master

Conversation

@gearonixx
Copy link
Copy Markdown

Problem

On Wayland, SeparatePanel renders its own client-side shadow via Shadow::paint() and applies st::callShadow.extend as padding. However, on Wayland the compositor already provides window shadows.

Root Cause

createBorderImage() and initGeometry() unconditionally applied st::callShadow.extend as shadow padding and drew the shadow, without checking whether the platform already provides compositor-level shadows.

how_it_was

Fix

fixed_state

Affected file

  • ui/widgets/separate_panel.cpp (in desktop-app/lib_ui)

Testing

On Wayland SeparatePanel should display with compositor-provided shadow only

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@john-preston john-preston force-pushed the master branch 2 times, most recently from 79acb05 to 1684ddb Compare April 28, 2026 09:21
@gearonixx
Copy link
Copy Markdown
Author

@ilya-fedin

@ilya-fedin
Copy link
Copy Markdown
Contributor

However, on Wayland the compositor already provides window shadows.

I can't confirm that. With your patch the window becomes shadow-less on Wayland.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants