Fix DynamoDB listing assertion#6786
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
22cc487 to
5cc30ae
Compare
5cc30ae to
8d33702
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The previous assert used assert(condition, message), which creates a truthy tuple in Python and silently disables the failure path.
Matching Notes
The stricter file check now requires the file name to start with the requested zero-padded version and end with .json, while still allowing UUID-suffixed staged commit files such as 00000000000000000001..json.
Validation
Did not run the full AWS/Spark integration test locally.