Skip to content

Fix DynamoDB listing assertion#6786

Open
fallintoplace wants to merge 1 commit into
delta-io:masterfrom
fallintoplace:fix/dynamodb-listing-assert
Open

Fix DynamoDB listing assertion#6786
fallintoplace wants to merge 1 commit into
delta-io:masterfrom
fallintoplace:fix/dynamodb-listing-assert

Conversation

@fallintoplace
Copy link
Copy Markdown

@fallintoplace fallintoplace commented May 14, 2026

Summary

  • Move DynamoDB commit coordinator S3 listing validation into a small helper.
  • Fix the missing-Contents assertion so required files fail the test when absent.
  • Add focused regression checks for missing Contents, UUID-suffixed staged commit files, and non-json suffixes.
  • Run the helper regression checks from the Build GitHub Actions workflow before heavier setup.

Root Cause

The previous assert used assert(condition, message), which creates a truthy tuple in Python and silently disables the failure path.

Matching Notes

The stricter file check now requires the file name to start with the requested zero-padded version and end with .json, while still allowing UUID-suffixed staged commit files such as 00000000000000000001..json.

Validation

  • python3 -m py_compile spark/src/main/java/io/delta/dynamodbcommitcoordinator/integration_tests/dynamodb_commitcoordinator_integration_test.py spark/src/main/java/io/delta/dynamodbcommitcoordinator/integration_tests/_dynamodb_commitcoordinator_listing.py
  • python3 spark/src/main/java/io/delta/dynamodbcommitcoordinator/integration_tests/_dynamodb_commitcoordinator_listing.py
  • cd spark/src/main/java/io/delta/dynamodbcommitcoordinator/integration_tests && python3 _dynamodb_commitcoordinator_listing.py
  • git diff --check

Did not run the full AWS/Spark integration test locally.

@fallintoplace fallintoplace force-pushed the fix/dynamodb-listing-assert branch 2 times, most recently from 22cc487 to 5cc30ae Compare May 14, 2026 19:46
@fallintoplace fallintoplace force-pushed the fix/dynamodb-listing-assert branch from 5cc30ae to 8d33702 Compare May 14, 2026 19:49
@fallintoplace fallintoplace marked this pull request as ready for review May 15, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant