[Spark] Use CatalogManaged commits in UniForm UC tests#6779
Open
xzhseh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR updates
UniFormE2EIcebergUCSuiteso the UC-backed UniForm E2E tests use the current CatalogManaged table setup instead of injecting legacy coordinated commits coordinator table properties. The suite now enablesCatalogOwnedTableFeaturethrough the table feature property, bootstraps CatalogManaged commits with the in-memory coordinator used by existing tests, assigns the UC table id through a metadata update that simulates catalog integration, and then switches subsequent commits to the in-memoryUCCommitCoordinatorClient.UCBackedDeltaCatalognow reads the table id from metadata configuration directly, which matches where the CatalogManaged path stores the catalog table id.The shared UniForm E2E base keeps the REORG upgrade test enabled by default, but the UC-backed CatalogManaged suite opts out of that specific positive REORG path because CatalogManaged tables intentionally block REORG in production. The rest of the UC-backed UniForm E2E coverage still runs through CREATE, INSERT, UPDATE, DELETE, CREATE OR REPLACE SHALLOW CLONE, partitions, and nested schemas with the native Iceberg reader.
How was this patch tested?
Ran locally with Java 17 and Spark 4.0.1:
Result: 10 tests passed.