[KERNEL] Rename srid to crs for Geospatial types#6774
Open
milastdbx wants to merge 2 commits into
Open
Conversation
milastdbx
changed the title
uros-db
approved these changes
May 13, 2026
Collaborator
|
Changes look good to me, but CI needs to be recovered. |
thinh2
approved these changes
May 16, 2026
thinh2
left a comment
thinh2
left a comment
There was a problem hiding this comment.
lgtm! can you take a look at the CI error as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
PRs that introduced geospatial types wrongly named arguments of Geometry/Geography as SRID, whereas proper terminology is CRS.
SRID refers to a way to lookup a CRS definition by identifier and is not uniquely identified, where as a CRS is superset of this, and is more precise that it allows and supprots other formats than SRID - such as
EPSG:4326for exampleHow was this patch tested?
Refactor change
Does this PR introduce any user-facing changes?
API methods have changed