Remove CCv1 DDL validation surface#6771
Open
xzhseh wants to merge 1 commit into
Open
Conversation
ctring
approved these changes
May 13, 2026
Contributor
ctring
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up!
bcaeb98 to
3c90c1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the CCv1 (Coordinated Commits v1) DDL validation surface from Delta. The validation logic this PR removes guarded property changes on CCv1 tables at DDL time (create, replace, alter, clone). With CCv1 deprecated in favor of catalog-owned coordination, the validations are no longer reachable in OSS and the corresponding helpers and test suites can be deleted.
Specifically:
CoordinatedCommitsUtils: removes the DDL-time validation helpers and the surrounding plumbing (called fromOptimisticTransaction,CloneTableBase,CreateDeltaTableCommand, andalterDeltaTableCommands). The remaining catalog-owned validation continues to live inCatalogOwnedTableUtilsand is unchanged.CoordinatedCommitsPropertySuiteBaseandCoordinatedCommitsUtilsSuite: deleted in full since their coverage was specific to the removed validation paths.CoordinatedCommitsSuite: trims the tests that asserted the removed validation behavior; the remaining tests cover commit coordinator wiring and stay.How was this patch tested?
The retained tests in
CoordinatedCommitsSuiteexercise the remaining commit coordinator wiring.CatalogOwnedEnablementSuitecovers the validation path that is the long-term replacement.Does this PR introduce any user-facing changes?
No.