DLPX-97390 Embed connector version in Windows installer artifact filename#394
Draft
suyash-jai wants to merge 1 commit into
Draft
DLPX-97390 Embed connector version in Windows installer artifact filename#394suyash-jai wants to merge 1 commit into
suyash-jai wants to merge 1 commit into
Conversation
suyash-jai
force-pushed
the
dlpx/pr/suyash-jai/20d602d7-1476-4f82-b9bf-39f9fb350858
branch
3 times, most recently
from
5872deb to
df1f465
Compare
…name Read connectorVersion from build.gradle and copy the installer as DelphixConnectorInstaller-<ver>.exe instead of the flat name, allowing downstream pipeline stages (devops-gate stage0) to discover the version from the filename and publish under a version-namespaced directory. PR URL: https://www.github.com/delphix/linux-pkg/pull/394
suyash-jai
changed the title
suyash-jai
force-pushed
the
dlpx/pr/suyash-jai/20d602d7-1476-4f82-b9bf-39f9fb350858
branch
from
df1f465 to
5d80d0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The linux-pkg windows-connector build produces a flat
DelphixConnectorInstaller.exewith no version information. Downstream pipeline stages (devops-gate stage0) have no way to determine which connector version the artifact corresponds to, making it impossible to publish under a version-namespaced directory.Solution
Read
connectorVersionfrom the checked-outbuild.gradleand copy the installer asDelphixConnectorInstaller-<ver>.exeinstead of the flat name. This allows devops-gate stage0 to discover the version from the filename and publish underwindows-connector/<ver>/DelphixConnectorInstaller.exe.Companion change: devops-gate DLPX-97389 consumes the versioned filename and creates the version directory in the per-build S3 bucket and on the download center.
Testing Done
Pre-push appliance build verified —
windows-connector/2.1.0.0/DelphixConnectorInstaller.exepresent in the per-build S3 bucket alongsideSHA256SUMSandMD5SUMS.